[PATCH] D54504: [stack-safety] Local analysis implementation

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:58
+
+struct CallInfo {
+  const GlobalValue *GV = nullptr;
----------------
Please add a short comment to this struct.
Maybe rename it to CallUseInfo? It describes a use of an address in a function call argument, not the call itself; also mention that Range is not access range, but an offset range.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:239
+/// Check whether a given allocation must be put on the safe
+/// stack or not. The function analyzes all uses of AI and checks whether it is
+/// only accessed in a memory safe way (as decided statically).
----------------
Please update the comment. This is not only about safe stack.


Repository:
  rL LLVM

https://reviews.llvm.org/D54504