[PATCH] D54546: [ARM] Don't expand sdiv

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 14:42:27 PST 2018


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3237
+    if (DAG.getMachineFunction().getFunction().optForMinSize() &&
+        !VT.isVector())
+      return SDValue();
----------------
Instead of isVector() should this be based on operation legality? Promotion/expansion could be just as (or more?) expensive as the pow2 expansion. i64 on 32-bits targets for instance.


https://reviews.llvm.org/D54546





More information about the llvm-commits mailing list