[PATCH] D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

I also don't understand how it works. 
What happens if you do this

  x = malloc()
  dlopen("asan.so");
  free(x)

This needs to be a) covered by test and b) explained in comments.



================
Comment at: lib/asan/asan_internal.h:114
 
-// Add convenient macro for interface functions that may be represented as
-// weak hooks.
+#if SANITIZER_SUPPORTS_INIT_FOR_DLOPEN
+bool InitIsViaDlopen();
----------------
please avoid introducing new ifdefs. There are plenty of them already, but no reason to make things worse. 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54469