[PATCH] D53596: [ThinLTO] Fix a crash in lazy loading of Metadata

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a reviewer: aprantl.
dexonsmith added a comment.

Sorry, I missed your questions.  Thanks for pinging.

I wasn’t concerned about this patch going in.  I was just concerned we may have had compile time regressions already.  Metadata forward references are quite expensive to track and resolve.

But I think I’d misread the patch entirely.  Is see this is just loosening to Metadata .

- Am I correct that somehow the scope field is not an MDNode?  The verifier should fail for that, unless something has changed.  @aprantl can you take a quick look?
- Can we have a positive test for what the debug info should like like here, rather than just a crash test?


Repository:
  rL LLVM

https://reviews.llvm.org/D53596