[PATCH] D54487: Implement llvm.commandline named metadata

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

In https://reviews.llvm.org/D54487#1297520, @probinson wrote:

> I don't really see a need for a new directive, it's convenient but does nothing you couldn't do with existing directives.
>  It does have some downside, in that it's supported only by the LLVM integrated assembler.


That's very reasonable; I will update the patch to remove the new directive.

In https://reviews.llvm.org/D54487#1297947, @manojgupta wrote:

> Doesn't clang already has -grecord-gcc-switches option (https://clang.llvm.org/docs/ClangCommandLineReference.html#debug-information-flags) ?


Yes, but the -g and -f variants have different purposes. This patch adds the -f version to embed the flags in e.g. an ELF section, rather than the -g version which embeds it in e.g. DWARF.


Repository:
  rL LLVM

https://reviews.llvm.org/D54487