[PATCH] D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin.

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 06:56:58 PST 2018


kubamracek added inline comments.


================
Comment at: lib/asan/asan_rtl.cc:403
+    asan_init_is_running = false;
+    Report("AddressSanitizer init is being performed for dlopen().\n");
+    HandleDlopenInit();
----------------
Change this to print only under verbose mode.


================
Comment at: lib/sanitizer_common/sanitizer_platform.h:348-352
+#if SANITIZER_MAC
+#define SANITIZER_SUPPORTS_INIT_FOR_DLOPEN 1
+#else
+#define SANITIZER_SUPPORTS_INIT_FOR_DLOPEN 0
+#endif
----------------
Why do we need this? I'd remove it.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54469





More information about the llvm-commits mailing list