[PATCH] D54237: Constant folding and instcombine for saturating adds

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 06:16:50 PST 2018


bjope added a comment.

In https://reviews.llvm.org/D54237#1298354, @RKSimon wrote:

> Please can you add vector constant folding tests + support?


Isn't it better to land this one and https://reviews.llvm.org/D54274 first since they basically are ready?
I think they are ok and reviewed (I think the only thing blocking was the @RKSimon request to extract APInt stuff and that is done).

If we need to support vectors also at once, then I think you should merge the add/sub patches into one big pile (otherwise it just complicates review and patch handling for @nikic since the "subtraction" patch basically rewrites lots of the things added in the "addition" patch.


https://reviews.llvm.org/D54237





More information about the llvm-commits mailing list