[llvm] r346861 - Document how to comment an actual parameter.
Paul Robinson via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 14 05:43:20 PST 2018
Author: probinson
Date: Wed Nov 14 05:43:19 2018
New Revision: 346861
URL: http://llvm.org/viewvc/llvm-project?rev=346861&view=rev
Log:
Document how to comment an actual parameter.
Differential Revision: https://reviews.llvm.org/D54446
Modified:
llvm/trunk/docs/CodingStandards.rst
Modified: llvm/trunk/docs/CodingStandards.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CodingStandards.rst?rev=346861&r1=346860&r2=346861&view=diff
==============================================================================
--- llvm/trunk/docs/CodingStandards.rst (original)
+++ llvm/trunk/docs/CodingStandards.rst Wed Nov 14 05:43:19 2018
@@ -305,6 +305,21 @@ useful to use C style (``/* */``) commen
#. When writing a source file that is used by a tool that only accepts C style
comments.
+#. When documenting the significance of constants used as actual parameters in
+ a call. This is most helpful for ``bool`` parameters, or passing ``0`` or
+ ``nullptr``. Typically you add the formal parameter name, which ought to be
+ meaningful. For example, it's not clear what the parameter means in this call:
+
+ .. code-block:: c++
+
+ Object.emitName(nullptr);
+
+ An in-line C-style comment makes the intent obvious:
+
+ .. code-block:: c++
+
+ Object.emitName(/*Prefix=*/nullptr);
+
Commenting out large blocks of code is discouraged, but if you really have to do
this (for documentation purposes or as a suggestion for debug printing), use
``#if 0`` and ``#endif``. These nest properly and are better behaved in general
More information about the llvm-commits
mailing list