[llvm] r346844 - Print newline after banner for ModulePass

Sven van Haastregt via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 02:05:28 PST 2018


Author: svenvh
Date: Wed Nov 14 02:05:28 2018
New Revision: 346844

URL: http://llvm.org/viewvc/llvm-project?rev=346844&view=rev
Log:
Print newline after banner for ModulePass

Before this commit, `llc -print-after-all` would print something like:

  *** IR Dump After Pre-ISel Intrinsic Lowering ***; ModuleID = ...

Emit a newline such that ModuleID appears on a line by its own.

Modified:
    llvm/trunk/lib/IR/IRPrintingPasses.cpp
    llvm/trunk/test/Other/2010-05-06-Printer.ll

Modified: llvm/trunk/lib/IR/IRPrintingPasses.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/IRPrintingPasses.cpp?rev=346844&r1=346843&r2=346844&view=diff
==============================================================================
--- llvm/trunk/lib/IR/IRPrintingPasses.cpp (original)
+++ llvm/trunk/lib/IR/IRPrintingPasses.cpp Wed Nov 14 02:05:28 2018
@@ -27,7 +27,8 @@ PrintModulePass::PrintModulePass(raw_ost
       ShouldPreserveUseListOrder(ShouldPreserveUseListOrder) {}
 
 PreservedAnalyses PrintModulePass::run(Module &M, ModuleAnalysisManager &) {
-  OS << Banner;
+  if (!Banner.empty())
+    OS << Banner << "\n";
   if (llvm::isFunctionInPrintList("*"))
     M.print(OS, nullptr, ShouldPreserveUseListOrder);
   else {

Modified: llvm/trunk/test/Other/2010-05-06-Printer.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/2010-05-06-Printer.ll?rev=346844&r1=346843&r2=346844&view=diff
==============================================================================
--- llvm/trunk/test/Other/2010-05-06-Printer.ll (original)
+++ llvm/trunk/test/Other/2010-05-06-Printer.ll Wed Nov 14 02:05:28 2018
@@ -10,10 +10,12 @@ define void @foo(){
   ret void
 }
 
+;ALL-NOT: IR Dump After {{.*}}; ModuleID =
 ;ALL: define void @tester()
 ;ALL: define void @foo()
 ;ALL: ModuleID =
 
 ;FOO: IR Dump After
+;FOO-EMPTY:
 ;FOO-NEXT: define void @foo()
 ;FOO-NOT: define void @tester




More information about the llvm-commits mailing list