[PATCH] D52010: RegAllocFast: Rewrite and improve

Aleksandar Beserminji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 00:20:14 PST 2018


abeserminji added a comment.

>From what I found in https://reviews.llvm.org/rL336328, I believe that the idea was to mark registers as implicit-def which would prevent such an error.
One of the comments say:

  // The scratch registers here with the EarlyClobber | Define | Implicit
  // flags is used to persuade the register allocator and the machine
  // verifier to accept the usage of this register.

When I do --print-before=regallocfast I get these flags included:

  ...implicit-def dead early-clobber %10:gpr32

But I am not sure if that's enough, or if the new implementation is taking this into account.


Repository:
  rL LLVM

https://reviews.llvm.org/D52010





More information about the llvm-commits mailing list