[PATCH] D54499: [codeview] Make "clang -g" emit codeview by default when targetting MSVC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 17:27:50 PST 2018


rnk added inline comments.


================
Comment at: clang/test/CodeGen/dwarf-version.c:33
+// RUN: %clang -target i686-pc-windows-msvc -gdwarf -gcodeview -S -emit-llvm -o - %s \
+// RUN:     | FileCheck %s --check-prefixes=VER4,CODEVIEW
 int main (void) {
----------------
smeenai wrote:
> Is it worth adding a test for a non msvc target to ensure the default for `-g` is still DWARF?
Yeah, let's do it. It's covered elsewhere, but encoding it here as intentional is good.


https://reviews.llvm.org/D54499





More information about the llvm-commits mailing list