[PATCH] D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:2417
+// extract symbols when .debug_gnu_pubnames is absent. This function implements
+// a subset of it to improve coverage of the .gdb_index symbol table.
+static void extractSymbol(DWARFDie D, uint32_t Idx,
----------------
Can you document what the different subset is?


================
Comment at: ELF/SyntheticSections.cpp:2439
+    extractSymbol(Child, Idx, Ret);
+    Child = Child.getSibling();
+  }
----------------
>From a quick look: what if DW_AT_sibling isn't there? Does this still work?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54497