[PATCH] D54461: [CMake] Support cross-compiling with multi-stage builds

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

One slightly nitpicky comment.



================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:169
+
+    set(resource_dir "${LLVM_LIBRARY_DIR}/clang/${CLANG_VERSION}")
+    set(flag_types ASM C CXX MODULE_LINKER SHARED_LINKER EXE_LINKER)
----------------
This could be problematic if the cross-compilation flow was ever hit using a non-clang compiler. I can't, off the top of my head, think of a use case where it would, but it might be worth checking `CMAKE_<LANG>_COMPILER_ID` to verify that it is `*Clang`.


Repository:
  rL LLVM

https://reviews.llvm.org/D54461