[PATCH] D54486: BumpPtrAllocator: Add a couple of fancy wrapper methods around identifyObject().

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 12:24:02 PST 2018

Previous message: [PATCH] D54486: BumpPtrAllocator: Add a couple of fancy wrapper methods around identifyObject().
Next message: [PATCH] D54487: Implement llvm.commandline named metadata
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

LGTM, but I would drop the word "convenient", and add an explicit `\return` section in doxygen.


Repository:
  rL LLVM

https://reviews.llvm.org/D54486

Previous message: [PATCH] D54486: BumpPtrAllocator: Add a couple of fancy wrapper methods around identifyObject().
Next message: [PATCH] D54487: Implement llvm.commandline named metadata
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list