[PATCH] D48955: [libc++] Improve diagnostics for non-const comparators and hashers in associative containers

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 09:32:52 PST 2018


ldionne added a comment.

In https://reviews.llvm.org/D48955#1297140, @ldionne wrote:

> In https://reviews.llvm.org/D48955#1258146, @mclow.lists wrote:
>
> > If you can build this w/GCC in C++03 mode, then I'm fine with it.
>
>
> I can't run the tests with GCC in C++03 mode -- I get thousands of errors unrelated to this patch.


But the two tests I modified do pass, since they are unsupported on GCC. Am I good to go?


Repository:
  rCXX libc++

https://reviews.llvm.org/D48955





More information about the llvm-commits mailing list