[PATCH] D54096: [WebAssembly] Add support for the event section

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: include/llvm/BinaryFormat/Wasm.h:80
+  // Kind of event. Currently only WASM_EVENT_ATTRIBUTE_EXCEPTION is possible.
+  uint32_t Attribute;
+  uint32_t SigIndex;
----------------
Should this be called Kind or Type?  Or is it more of a bitfield?

If its Type then perhaps that SigIndex should be in union:

e.g.

```
struct WasmEventType {
  uint32_t Kind
  union {
    ExceptionSigIndex;
  };
};
```

still lgtm in any case as this stuff can be iterated on.


Repository:
  rL LLVM

https://reviews.llvm.org/D54096