[PATCH] D54327: Adding debug info to support Fortran (part 3)

[John Reagan via Phabricator via llvm-commits]

JohnReagan added a comment.

In https://reviews.llvm.org/D54327#1293577, @schweitz wrote:

> In https://reviews.llvm.org/D54327#1293281, @JohnReagan wrote:
>
> > I don't understand the need for the "common alpha" global variable.
>
>
> It's not strictly required to have it explicitly named. Our implementation allocates a COMMON block as an "untyped" block of memory and each subprogram can, of course, remap the storage units to its own list of variable names.  The DW_TAG_common_block does require a DW_AT_location, and the !DIGlobalVariable fulfills that requirement.


Ah, yes I see.  I forgot that for us, we have a platform-specific ELF section flag for "overlay" sections which are common blocks.  We don't need the extra hidden weak variable to be the intermediate allocator.


Repository:
  rL LLVM

https://reviews.llvm.org/D54327