[PATCH] D53975: Start adding the supporting code to perform out-of-process allocator enumeration.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In https://reviews.llvm.org/D53975#1296359, @kcc wrote:

> I'm puzzled. 
>  Why would you make AddressSpaceView non-zero-sized given that Load is a static member function?


Sorry. I was thinking of the old implementation and not the new implementation (I shouldn't reply when I'm really tired). Yes, you're right all implementations of `AddressSpaceView` will be zero-sized.

> I would like to see a test that uses a non-default implementation of AddressSpaceView.

Yes I will be landing tests in two forms.

- Unit tests that check on all platforms that it's possible to instantiate the allocator and use it with `RemoteAddressSpaceView` (these won't actually launch a separate process).
- A lit test that that acts like one of Darwin's memory analysis tools by enumerating all the allocations of another process that is using ASan.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53975