[PATCH] D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin.

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/asan/asan_flags.inc:164
           " when other library has to be preloaded system-wide)")
+ASAN_FLAG(bool, disable_init, false,
+          "If true, disables all initialization of the "
----------------
Why to add a flag for it? As far as I understand it, we require this option to workaround some issue on Darwin and it's not needed so far by others. If I understanding removal of this property will break startup on Darwin.

If so, shouldn't this be just Darwin specific hardcoded property rather than generalized and unsupported option for everybody?


================
Comment at: lib/asan/asan_internal.h:117
+#else
+void HandleDisabledInit() { Die(); }
+#endif
----------------
Shouldn't we add 'static inline'? Some compilers may complain that there is no prototype for a function.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54469