[PATCH] D54277: Extend VFS with function to get external path.

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 00:39:09 PST 2018


sammccall added a comment.

In https://reviews.llvm.org/D54277#1296400, @JDevlieghere wrote:

> In https://reviews.llvm.org/D54277#1296175, @sammccall wrote:
>
> > I don't understand the concept of an "external path". What is it in the general case, when would you want to pass a path through this function vs using it directly?
> >
> > From the patch description, it sounds like it may be specific to LLDB and/or RedirectingFileSystem. If so, maybe it shouldn't be on the interface?
>
>
> It's true that this is only relevant for VFS implementations that are somehow backed by disk. I'm curious what you have in mind. How would it not be on the interface and still work transparently?


I can't really answer these questions without knowing what an external path is or when you'd want to use it.
Could you describe it here or add some documentation to the patch?


https://reviews.llvm.org/D54277





More information about the llvm-commits mailing list