[PATCH] D54447: [WebAssembly] Fix broken assumption that all bitcasts are to functions types

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAddMissingPrototypes.cpp:129
+          Inst->replaceAllUsesWith(NewCast);
+          Inst->eraseFromParent();
+        } else if (ConstantExpr *Const = dyn_cast<ConstantExpr>(U)) {
----------------
dschuff wrote:
> isn't this modifying F.uses while iterating over it?
I'm not sure.   Is the `eraseFromParent` call that makes you think that?  Any idea how would I validate that?    


Repository:
  rL LLVM

https://reviews.llvm.org/D54447