[PATCH] D54449: [compiler-rt][builtins][PowerPC] Enable builtins tests on PowerPC 64 bit LE

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Conceptually, `COMPILER_RT_ABI` is the calling convention used by all compiler-rt functions. It is explicitly used everywhere because it may be different from the default calling convention on some targets. In practice I believe it only affects ARM, where the calling convention uses ARM's soft-float ABI (where IIRC floats are passed in integer registers) even on targets that use the hard-float ABI by default. The compiler knows the calling conventions and emits the right code when it emits the libcalls, and the ABI declaration on the implementations causes the right calling convention to be used there. The unusual thing about the tests is that they locally declare the compiler-rt functions explicitly. So this declaration has to match the implementation. It may not matter for PPC but my recommendation would be "just use it everywhere in compiler-rt" for simplicity.


https://reviews.llvm.org/D54449