[PATCH] D54351: [AMDGPU] combine extractelement into several selects

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: test/CodeGen/AMDGPU/extract_vector_dynelt.ll:2
+; RUN: llc -march=amdgcn -mcpu=fiji -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN %s
+
+; GCN-LABEL: {{^}}float4_extelt:
----------------
rampitec wrote:
> arsenm wrote:
> > Should have some 8 and 16-bit element vectors (and 1-bit since those always break things)
> Added tests except for i1. Extract i1 element is already broken in the DAGTypeLegalizer::SplitVecOp_EXTRACT_VECTOR_ELT() before my patch. I have a testcase but that needs to be a separate independent patch wrt legalizer.
I have fixed i1 splitvector, it is here in the review.
I can commit it separately, but the testcase from it is in this revieq.


https://reviews.llvm.org/D54351