[PATCH] D54433: [PowerPC][NFC] Macro for register set defs for the Asm Parser

[Jinsong Ji via Phabricator via llvm-commits]

jsji added a comment.

Good idea! Looks like most of these register sets are common for assembler/disassembler, can we do one step further to put all these in one include file? Or even better: generated that include file by TableGen! :)



================
Comment at: lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp:62
 
 // FIXME: These can be generated by TableGen from the existing register
 // encoding values!
----------------
Looks like that it would be even better if we can generate all these by TableGen. 

DisassemblerEmitter.cpp is already generating differently for X86/WebAssembly/ARM, it should be fair for us to add PPC specific logic there. 


https://reviews.llvm.org/D54433