[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: include/llvm/Bitcode/LLVMBitCodes.h:479
   FUNC_CODE_INST_UNREACHABLE = 15, // UNREACHABLE
 
   FUNC_CODE_INST_PHI = 16, // PHI:        [ty, val0,bb0, ...]
----------------
cameron.mcinally wrote:
> arsenm wrote:
> > cameron.mcinally wrote:
> > > Same thing here about organizing the enum members.
> > Any guesses for why 14 wasn't used before?
> It looks like @void removed it as part of the "unwind removal" project. There's not a whole lot of history beyond that attached. The commit is r149911, and the message says:
> 
> "[unwind removal] Remove a the obsolete 'unwind' enum value."
> 
> That line was the only one that changed in this commit. 
I don't think we should reuse the function code number.


Repository:
  rL LLVM

https://reviews.llvm.org/D53877