[PATCH] D54418: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): replace SetVector with custom BitVectorVector
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 12 03:17:48 PST 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D54418#1295286, @RKSimon wrote:
> I'm not convinced you need a new type here - why don't you just use BitVector (or SparseBitVector?) and create a helper function for the insert/erase?
I'm not sure i follow your suggestion.
In `SetVector`, `set_` is a `private` member variable, i can't reach it from my custom function.
Repository:
rL LLVM
https://reviews.llvm.org/D54418
More information about the llvm-commits
mailing list