[PATCH] D54383: [llvm-exegesis] Analysis: writeMeasurementValue(): don't alloc string for double each time.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added a comment.

I'm not entirely convinced here:

- The code is harder to read,
- the formatting pattern and the SmallString size may go out of sync,
- the performance win is not that big.



================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:101
+      OS, llvm::formatv("{0:F}", Value)
+              .sstr<1 + std::numeric_limits<decltype(Value)>::max_digits10>());
 }
----------------
Why `1 + ...`?


Repository:
  rL LLVM

https://reviews.llvm.org/D54383