[PATCH] D54415: [llvm-exegesis] InstructionBenchmarkClustering::rangeQuery(): reserve for the upper bound of Neighbors

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:140
   }
+  // assert(Neighbors.capacity() == (Points_.size() - 1));
+  // ^ True, but it is not quaranteed to be true in all the cases.
----------------
I've lost in the patch series :( I think I understand the DBSCAN implementation well enough now. You may consider merging some revisions related to the vector optimization and commit them at once? They should be quite obvious.

I understand that reordering/rebasing several commits is painful... (I am also try avoiding `git rebase --onto readPubNamesAndTypes HEAD\^`)


Repository:
  rL LLVM

https://reviews.llvm.org/D54415