[PATCH] D54249: [WebAssembly] Initial support for shared objects (-shared)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Can you add this to ReleaseNotes?



================
Comment at: wasm/Driver.cpp:403
   Config->StripDebug = Args.hasArg(OPT_strip_debug);
-  Config->CompressRelocations = Args.hasArg(OPT_compress_relocations);
+  Config->Pie = Args.hasFlag(OPT_pie, OPT_no_pie, false);
+  Config->Shared = Args.hasArg(OPT_shared);
----------------
Sort alphabetically.


================
Comment at: wasm/Driver.cpp:489
 
+    if (Config->Pic) {
+      static llvm::wasm::WasmGlobalType GlobalTypeI32 = {WASM_TYPE_I32, false};
----------------
Can you add a comment for this code block so that it is clear what we are doing if Config->Pic?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54249