[PATCH] D53408: [PPC64] Long branch thunks.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Symbols.cpp:141
 
+uint64_t Symbol::getLongBranchOffset() const {
+  assert(BranchltIndex != 0xffff);
----------------
getPPC64LongBranchOffset


================
Comment at: ELF/Symbols.cpp:157
 
+uint64_t Symbol::getLongBranchTableVA() const {
+  assert(BranchltIndex != 0xffff);
----------------
getPPC64LongBranchTableVA


================
Comment at: ELF/Symbols.h:92
+  // An index into the .branch_lt section on PPC64.
+  uint16_t BranchltIndex = -1;
+
----------------
I'd name this PPC64BranchltIndex to make it clear that no one except PPC64 uses this member.


================
Comment at: ELF/SyntheticSections.h:1012
   IgotPltSection *IgotPlt;
+  PPC64LongBranchTargetSection *LongBranchTarget;
   MipsGotSection *MipsGot;
----------------
PPC64LongBranchTarget.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53408