[PATCH] D54376: [ELF] Change GnuPub{Names, Types}Section from StringRef to LLDDWARFSection

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/trunk/ELF/SyntheticSections.cpp:2517
     ObjFile<ELFT> *File = Sections[I]->getFile<ELFT>();
     DWARFContext Dwarf(make_unique<LLDDwarfObj<ELFT>>(File));
 
----------------
Is the object you get with the following line

  auto &Obj = static_cast<const LLDDwarfObj<ELFT> &>(Dwarf.getDWARFObj());

the same object as you create at this line? If so, I'd pass the object you are creating with make_unique to readPubNamesAndTypes instead of passing a Dwarf object.


Repository:
  rL LLVM

https://reviews.llvm.org/D54376