[PATCH] D54380: [llvm-objdump] Add symbol 'O' for object data

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 11 17:27:55 PST 2018


kristina added a comment.

In https://reviews.llvm.org/D54380#1294974, @Higuoxing wrote:

> In https://reviews.llvm.org/D54380#1294716, @kristina wrote:
>
> > Grouped and linked all related commits. Closing.
>
>
> Sorry for that, I should have run 'test all' locally ... Sorry for bothering you too much! Thanks a lot!


Don't worry, it's not your fault, there were a lot of targets that used llvm-objdump in their tests
that are unlikely to be built by most locally (ie. Hexagon). I guess at the core a lesson for the future
is to grep around for uses of said tool in tests since without the target enabled, you will not be
eligible to run the test and while the majority of the tests work on `X86` (which is usually enabled by
default for almost everyone), target specific tests often require said target backend being enabled.


Repository:
  rL LLVM

https://reviews.llvm.org/D54380





More information about the llvm-commits mailing list