[PATCH] D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Those asserts are validating the metadata correctness. Deleting them is hiding a bug I think.



================
Comment at: test/Transforms/InstCombine/select-pr39595.ll:10
+; Function Attrs: inlinehint norecurse
+define linkonce_odr dso_local i32 @foo(%0* dereferenceable(4)) local_unnamed_addr comdat !prof !1 {
+; CHECK-LABEL: foo
----------------
I dont' think most of the attributes on this function are necessary to show the bug.


================
Comment at: test/Transforms/InstCombine/select-pr39595.ll:19
+
+  %2 = getelementptr inbounds %2, %2* null, i32 0, i32 1
+  %3 = load i32*, i32** %2, align 4
----------------
Can we hit this bug without these loads?


================
Comment at: test/Transforms/InstCombine/select-pr39595.ll:31
+
+!1 = !{!"function_entry_count", i64 1}
+!2 = !{!"branch_weights", i32 1, i32 6}
----------------
This function_entry_count looks unnecessary to demonstrate the issue.


Repository:
  rL LLVM

https://reviews.llvm.org/D54359