[PATCH] D54277: Extend VFS with function to get external path.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere planned changes to this revision.
JDevlieghere added inline comments.


================
Comment at: lib/Support/VirtualFileSystem.cpp:1906-1907
 
+Optional<std::string>
+RedirectingFileSystem::getExternalPath(const Twine &Path) {
+  ErrorOr<Entry *> E = lookupPath(Path);
----------------
vsapsai wrote:
> Need to double check but at the first glance I have reservations about a case with nested  `RedirectingFileSystem`. Should `getExternalPath` go only through 1 level of indirection or all the way to real file system?
Good point. My use case would require all the way to the real FS. 


Repository:
  rL LLVM

https://reviews.llvm.org/D54277