[PATCH] D54378: Add Hurd triplet

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 10 08:46:16 PST 2018


chandlerc added a comment.

I really do find the break with convention here somewhat deeply unfortunate. It makes parsing and recognizing triples reliably much harder IMO. This really should be 'hurd-gnu' or 'mach-gnu' (or however you want to spell the 'OS' here).

If the only way to support this is to use the existing name, I still think that accepting arbitrary suffixes is a mistake. What do they mean? What do we do with them when canonicalizing? If there are suffixes, we need to know how to parse them and to do so accurately.


https://reviews.llvm.org/D54378





More information about the llvm-commits mailing list