[PATCH] D54291: [XRay] Add atomic fences around non-atomic reads and writes
JF Bastien via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 9 20:41:49 PST 2018
jfb added a comment.
In https://reviews.llvm.org/D54291#1293418, @efriedma wrote:
> What is the point of this change? The atomic_fetch_add operations already use memory_order_acq_rel, so the explicit fences are redundant.
Agreed, these are all redundant. Ideally the compiler just eliminates the fences, and your change was a no-op :-)
Repository:
rL LLVM
https://reviews.llvm.org/D54291
More information about the llvm-commits
mailing list