[PATCH] D54124: [llvm-readelf] Make llvm-readelf more compatible with GNU readelf.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 18:02:36 PST 2018


echristo added a comment.

In https://reviews.llvm.org/D54124#1293752, @rupprecht wrote:

> In https://reviews.llvm.org/D54124#1292583, @jhenderson wrote:
>
> > Okay, from my point of view, LGTM (with a nit). However, we should probably get some more buy-in on the RFC before breaking people's builds etc, so you might want to hold off on the commit for now.
> >
> > Any thoughts on how to drum up some more interest?
>
>
> I'll ping the thread you started, and I'd like to commit on Monday if there are no objections. I'm hoping this change is not so controversial.


As a not entirely unbiased person, but who has worked on this, I'm in favor of this at the moment.  Long term plans at the bottom...

> After this I'd like to switch to tablegen/liboption and support some merged args (e.g. "readelf -SW" seems to be a common usage)... that will be slightly more dangerous :)

Awesome.

I'd really like to see a better "multiple tools calling into the same library with different options and output decorators allowing compatibility with random tools/output" set of support in an ideal world here.

-eric


Repository:
  rL LLVM

https://reviews.llvm.org/D54124





More information about the llvm-commits mailing list