[PATCH] D51524: [ARM64] [Windows] Handle funclets

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Sorry, I lost track of this.



================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1681
+    BuildMI(MBB, FirstEpilogSEH, DL, TII->get(AArch64::ADRP))
+        .addReg(AArch64::X0, RegState::Define)
+        .addMBB(TargetMBB);
----------------
Yep, makes sense, put the address of the target MBB in X0. Do you have any assurance that X0 isn't used by normal epilogue code? At least on x86, sometimes RAX gets used for large SP updates.


================
Comment at: test/CodeGen/AArch64/wineh-try-catch.ll:13-15
+; The following checks that the unwind help object has -2 stored into it at
+; fp - 400 - 256 = fp - 656, which is on-entry sp - 48 + 32 - 656 =
+; on-entry sp - 672.  We check this offset in the table later on.
----------------
Tests with comments about the correctness of numbers that we filecheck for below are always worrying, but I have no better suggestions. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D51524