[PATCH] D54336: [FileCheck] introduce CHECK-COUNT-<num> repetition directive

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

Seems pretty reasonable to me. Pretty minor things below...



================
Comment at: include/llvm/Support/FileCheck.h:62
   /// Marks when parsing found a -NOT check combined with another CHECK suffix.
-  CheckBadNot
+  CheckBadNot,
+  /// Marks when parsing found a -COUNT directive with invalid count value.
----------------
nit: blank line here


================
Comment at: include/llvm/Support/FileCheck.h:69
+  FileCheckKind Kind;
+  unsigned Count; //< optional Count for some checks
+
----------------
I'd prefer to use an int throughout for this.


================
Comment at: lib/Support/FileCheck.cpp:587
+  if (Rest.consume_front("COUNT-")) {
+    long long Count;
+    if (Rest.consumeInteger(10, Count)) {
----------------
int64_t?


================
Comment at: lib/Support/FileCheck.cpp:855
                        StringRef Prefix, SMLoc Loc, const FileCheckPattern &Pat,
+		       unsigned MatchedCount,
                        StringRef Buffer, StringMap<StringRef> &VariableTable,
----------------
clang-format


Repository:
  rL LLVM

https://reviews.llvm.org/D54336