[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I hadn't thought about `-v`; I don't think the new diag is currently under `-v`? The first test isn't using that option...

I think we should encourage people to have warnings on when they develop their tests.  Having that separate from `-v` seems like a good thing, as `-v` obviously dumps a lot of info, most of which would ordinarily describe a test behaving exactly as intended.  A `-warn` option to turn everything on/off (default off) should be sufficient, at least for now when the number of different warnings is pretty small.  More fine-grained `-W` options seems like overkill.  These diags are mainly to help people write cleaner tests.  Oh, we should probably add a note to the docs somewhere, advising people to set `-warn` in the environment variable while writing new tests.


https://reviews.llvm.org/D53710