[PATCH] D54138: [WebAssembly] Read prefixed opcodes as ULEB128s

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 09:27:58 PST 2018


aardappel added inline comments.


================
Comment at: llvm/trunk/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp:141
+      return MCDisassembler::Fail;
+    if (PrefixedOpc < 0 || PrefixedOpc >= WebAssemblyInstructionTableSize)
       return MCDisassembler::Fail;
----------------
wait.. the extension opcode is a LEB, yet has max 256 possible values?


Repository:
  rL LLVM

https://reviews.llvm.org/D54138





More information about the llvm-commits mailing list