[PATCH] D49362: [ThinLTO] Internalize read only globals

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 07:36:29 PST 2018


evgeny777 added a comment.

Oh, my bad. `opt -function-import` gets index from `llvm-lto2`, not from `opt -thinlto-bc`. Sorry about that

However, there is still a small problem:

In `FunctionImport/funcimport.ll` we use index from `llvm-lto -thinlto`, for which propagateConstants hasn't been run. This results in internalizing `P.llvm.0`, which shouldn't happen, because it's writeable (from setfunc)
Can such thing occur in real life (i.e we use index from `llvm-lto -thinlto` in distrivuted build)?


https://reviews.llvm.org/D49362





More information about the llvm-commits mailing list