[PATCH] D54312: [CSP, Cloning] Update DuplicateInstructionsInSplitBetween to use DomTreeUpdater.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 06:53:11 PST 2018


fhahn created this revision.
fhahn added reviewers: junbuml, kuhar, NutshellySima, indutny, brzycki.

This patch updates DuplicateInstructionsInSplitBetween to update a DTU
instead of applying updates to the DT directly.

Given that there only are 2 users, I also updated them in this patch to
avoid churn.

I slightly moved the code in CallSiteSplitting around to reduce the
places where we have to pass in DTU. If necessary, I could split those
changes in a separate patch.

This fixes missing DT updates when dealing with musttail calls in
CallSiteSplitting, by using DTU->deleteBB.


https://reviews.llvm.org/D54312

Files:
  include/llvm/Transforms/Utils/Cloning.h
  lib/Transforms/Scalar/CallSiteSplitting.cpp
  lib/Transforms/Scalar/JumpThreading.cpp
  lib/Transforms/Utils/CloneFunction.cpp
  test/Transforms/CallSiteSplitting/musttail.ll
  unittests/Transforms/Utils/CloningTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54312.173320.patch
Type: text/x-patch
Size: 12731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181109/19a6a20e/attachment.bin>


More information about the llvm-commits mailing list