[PATCH] D54287: [WebAssembly] Implement TargetLowering hooks for vectors

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 17:47:48 PST 2018


tlively added a comment.

In https://reviews.llvm.org/D54287#1292355, @sbc100 wrote:

> Didn't effect any tests?   Presumably that means we are missing some?


Maybe. These functions are all called by target-independent optimizations that presumably are tested elsewhere. `shouldExpandBuildVectorWithShuffles` is actually never called right now, since we never expand `build_vector`s (but I'm considering changing that).


Repository:
  rL LLVM

https://reviews.llvm.org/D54287





More information about the llvm-commits mailing list