[PATCH] D54277: Extend VFS with function to get external path.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 15:56:57 PST 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D54277#1292180, @vsapsai wrote:

> How do you want it to work with symlinks? Would `getRealPath` be sufficient for your purpose?


I'm not sure how those two are related, other than the confusing name. As far as I can tell this only wraps the `realpath(3) ` call, which is definitely much too expensive to do in the "real" file system case. For symlinks I wouldn't really care, it's up to the user to resolve them if they matter.


Repository:
  rL LLVM

https://reviews.llvm.org/D54277





More information about the llvm-commits mailing list