[PATCH] D54266: [llvm-cov] Add lcov tracefile export format.

[Tony Allevato via Phabricator via llvm-commits]

allevato marked an inline comment as done.
allevato added a comment.

PTAL.

In https://reviews.llvm.org/D54266#1291921, @vsk wrote:

> I suggest adding a note in docs/ReleaseNotes.rst about this.


Done.

In https://reviews.llvm.org/D54266#1292039, @vsk wrote:

> Oh, I just realized this also needs an entry in CommandGuide (I think the file is called llvm-cov.rst).


Done.



================
Comment at: tools/llvm-cov/CodeCoverage.cpp:1015
+  if (ViewOpts.Format != CoverageViewOptions::OutputFormat::Text &&
+      ViewOpts.Format != CoverageViewOptions::OutputFormat::Lcov) {
+    error("Coverage data can only be exported as textual JSON or an "
----------------
vsk wrote:
> Dor1s wrote:
> > Just wondering whether we should add `json` format as well and document it instead of the `text`. Maybe eventually we'll be able to remove `text` at all to avoid any confusion? @vsk , what do you think?
> This sounds like a good follow-up. In retrospect picking the name ‘text’ wasn’t a good idea, it’s a bit ambiguous.
I'm happy to do this as a follow-up—deprecating an existing option feels better to do as a separate change.


Repository:
  rL LLVM

https://reviews.llvm.org/D54266