[PATCH] D54007: Use a data structure better suited for large sets in SimplificationTracker.
Ali Tamur via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 8 13:59:03 PST 2018
tamur updated this revision to Diff 173219.
tamur added a comment.
Oh, I had completely misseed the remove-and-add-again-later case, thanks for pointing out. I changed the underlying set from SmallPtrSet to SmallDenseMap to let it point to the valid index at the vector; I think this is the only way to handle removing in constant time (Allowing nullptr does not seem enough). It made the compilation time for my huge case to go up from 96 seconds to maybe 98 seconds, and should be unnoticable in 'normal' cases.
Repository:
rL LLVM
https://reviews.llvm.org/D54007
Files:
lib/CodeGen/CodeGenPrepare.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54007.173219.patch
Type: text/x-patch
Size: 8384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181108/cb06eef1/attachment.bin>
More information about the llvm-commits
mailing list