[PATCH] D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D54242#1291956, @JDevlieghere wrote:

> Is this going to be used for anything other than ranges? If not I'd slightly prefer `rangesBaseAddress` over `debugBaseAddress`.


Yeah, seems reasonable. (I'll hold off on actually making the naming change until I get a sense everyone's roughly on the same page)

It's /possible/ we would want to configure the use of certain forms (including base address specifiers) in debug_loclists.dwo in v4 mode (this change already only applies to v4 - in v5 we use rnglists & expect a conformant implementation that handles all the v5 loclist entry kinds) - seems GDB only supports the forms we already use in v4, even though there are more efficient forms we could use (& it only supports the efficient forms in v5 standard loclists - not the forms we use in v4... ). But probably best to just move to v5 there, rather than trying to get v4 support in GDB to handle it, then have a conditional flag for users who have the fixed GDB or don't, etc. See this commit for some details about that fiasco: http://llvm.org/viewvc/llvm-project?view=revision&revision=345326


Repository:
  rL LLVM

https://reviews.llvm.org/D54242