[PATCH] D54266: [llvm-cov] Add lcov tracefile export format.

[Max Moroz via Phabricator via llvm-commits]

Dor1s accepted this revision.
Dor1s added a comment.

Very nice!! LGTM!



================
Comment at: tools/llvm-cov/CodeCoverage.cpp:1015
+  if (ViewOpts.Format != CoverageViewOptions::OutputFormat::Text &&
+      ViewOpts.Format != CoverageViewOptions::OutputFormat::Lcov) {
+    error("Coverage data can only be exported as textual JSON or an "
----------------
Just wondering whether we should add `json` format as well and document it instead of the `text`. Maybe eventually we'll be able to remove `text` at all to avoid any confusion? @vsk , what do you think?


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:1037
+    // above.
+    llvm_unreachable("HTML export is not supported!");
+  case CoverageViewOptions::OutputFormat::Lcov:
----------------
nit: maybe re-phrase like "export in HTML is not supported" ?


Repository:
  rL LLVM

https://reviews.llvm.org/D54266