[PATCH] D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In https://reviews.llvm.org/D54125#1291935, @pirama wrote:

> In https://reviews.llvm.org/D54125#1291931, @smeenai wrote:
>
> > From the summary,
> >
> > "In ELF, symbols non-weak symbols"
> >
> > The first "symbols" seems extraneous?
>
>
> I fixed it in the commit message, but Phabricator seems to showing the commit message from the first patch.  I'll manually update the summary.


Yeah, Phabricator doesn't update the title or summary from the commit (after the initial diff creation) unless you pass `--verbatim` to `--arc-diff`. Doing so also restores the reviewers, subscribers, etc. from the original commit message, so it can end up dropping people who added themselves later.


Repository:
  rL LLVM

https://reviews.llvm.org/D54125